Update INotifyCollectionChanged events in MenuItems and FooterMenuItems of the NavigationView
#1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onview menu/footer items. - Fixed menu/footer items not updating with databinding source if items modified post init.
github-actions
bot
added
controls
…nt when updating from binding source
|
Fixed stackoverflow due to recursive call from collection change event when updating from binding source. |
|
Hi please look at (#1092) You don't need to add the items to another collection as it is an observable collection, any change to the collection will change the items. |
|
The initial items get added to the observable collection and update when you set the itemssource, but you aren't adding a binding to the itemssource; they're just being added from one to the other; so if the itemssource changes after the initial binding is done; the items do not update. |
pomianowski
reviewed
Jun 10, 2024
pomianowski
changed the title
INotifyCollectionChanged events in MenuItems and FooterMenuItems of the NavigationView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
If you modify a databound observable collection to navigationview menu/footer items and then modify that list later in the program, the ui will not update with the new items.
Issue Number: N/A
What is the new behavior?
Ui now updates when binding source is updated.
Other information